bnx2x: Fix incorrect link-up report
Fix a problem where link is reported to be up when SFP+ module is plugged in without cable. This occurs with specific module types which may generate temporary TX_FAULT indication. Solution is to avoid changing any link parameters when checking TX_FAULT indication while physical link is down. Signed-off-by: Yaniv Rosner <yanivr@broadcom.com> Signed-off-by: Ariel Elior <ariele@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
a429ec239c
commit
ad1d9ef3f7
|
@ -13360,6 +13360,10 @@ static u8 bnx2x_analyze_link_error(struct link_params *params,
|
||||||
DP(NETIF_MSG_LINK, "Link changed:[%x %x]->%x\n", vars->link_up,
|
DP(NETIF_MSG_LINK, "Link changed:[%x %x]->%x\n", vars->link_up,
|
||||||
old_status, status);
|
old_status, status);
|
||||||
|
|
||||||
|
/* Do not touch the link in case physical link down */
|
||||||
|
if ((vars->phy_flags & PHY_PHYSICAL_LINK_FLAG) == 0)
|
||||||
|
return 1;
|
||||||
|
|
||||||
/* a. Update shmem->link_status accordingly
|
/* a. Update shmem->link_status accordingly
|
||||||
* b. Update link_vars->link_up
|
* b. Update link_vars->link_up
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in a new issue