redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

airo: use simple_write_to_buffer

Browse source 
Simplify write file operation for /proc files by using
simple_write_to_buffer().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Akinobu Mita 2010-12-25 15:03:58 +09:00 committed by John W. Linville
parent 52671e43db
commit ad9082adfc
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
drivers/net/wireless/airo.c
View file

@ -4652,24 +4652,18 @@ static ssize_t proc_write( struct file *file,
size_t len, size_t len,
loff_t *offset ) loff_t *offset )
{ {
loff_t pos = *offset; ssize_t ret;
struct proc_data *priv = file->private_data; struct proc_data *priv = file->private_data;
if (!priv->wbuffer) if (!priv->wbuffer)
return -EINVAL; return -EINVAL;
if (pos < 0) ret = simple_write_to_buffer(priv->wbuffer, priv->maxwritelen, offset,
return -EINVAL; buffer, len);
if (pos >= priv->maxwritelen) if (ret > 0)
return 0; priv->writelen = max_t(int, priv->writelen, *offset);
if (len > priv->maxwritelen - pos)
len = priv->maxwritelen - pos; return ret;
if (copy_from_user(priv->wbuffer + pos, buffer, len))
return -EFAULT;
if ( pos + len > priv->writelen )
priv->writelen = len + file->f_pos;
*offset = pos + len;
return len;
} }
static int proc_status_open(struct inode *inode, struct file *file) static int proc_status_open(struct inode *inode, struct file *file)