redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

kgdboc,kgdbts: strlen() doesn't count the terminator 

This is an off by one because strlen() doesn't count the null
terminator.  We strcpy() these strings into an array of size
MAX_CONFIG_LEN.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
hifive-unleashed-5.1
Dan Carpenter 2010-03-15 07:28:00 -05:00 committed by Jason Wessel
parent 521cb40b0c
commit adb4b83c12
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/misc/kgdbts.c
View File

@ -988,7 +988,7 @@ static void kgdbts_run_tests(void)
static int kgdbts_option_setup(char *opt)
{
if (strlen(opt) > MAX_CONFIG_LEN) {
if (strlen(opt) >= MAX_CONFIG_LEN) {
printk(KERN_ERR "kgdbts: config string too long\n");
return -ENOSPC;
}

2
drivers/tty/serial/kgdboc.c
View File

@ -131,7 +131,7 @@ static void kgdboc_unregister_kbd(void)
static int kgdboc_option_setup(char *opt)
{
if (strlen(opt) > MAX_CONFIG_LEN) {
if (strlen(opt) >= MAX_CONFIG_LEN) {
printk(KERN_ERR "kgdboc: config string too long\n");
return -ENOSPC;
}