redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/ttm: Simplify ttm_dma_find_pool() (v2) 

Flip the logic of the comparison and remove
the redudant variable for the pool address.

(v2): Remove {} bracing.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
hifive-unleashed-5.1
Tom St Denis 2018-01-25 13:52:30 -05:00 committed by Alex Deucher
parent c68edaa0c1
commit add3d95d73
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
View File

@ -682,10 +682,10 @@ err_mem:
static struct dma_pool *ttm_dma_find_pool(struct device *dev,
enum pool_type type)
{
struct dma_pool *pool, *tmp, *found = NULL;
struct dma_pool *pool, *tmp;
if (type == IS_UNDEFINED)
return found;
return NULL;
/* NB: We iterate on the 'struct dev' which has no spinlock, but
* it does have a kref which we have taken. The kref is taken during
@ -698,13 +698,10 @@ static struct dma_pool *ttm_dma_find_pool(struct device *dev,
* thing is at that point of time there are no pages associated with the
* driver so this function will not be called.
*/
list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools) {
if (pool->type != type)
continue;
found = pool;
break;
}
return found;
list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools)
if (pool->type == type)
return pool;
return NULL;
}
/*