redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: ft1000: Remove useless return variables

Browse source 
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Peter Senna Tschudin 2014-05-20 12:33:44 +02:00 committed by Greg Kroah-Hartman
parent bf52695740
commit add6452615
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/staging/ft1000/ft1000-usb/ft1000_download.c
View file

@ -522,7 +522,6 @@ static void usb_dnld_complete(struct urb *urb)
static int write_blk_fifo(struct ft1000_usb *ft1000dev, u16 **pUsFile, static int write_blk_fifo(struct ft1000_usb *ft1000dev, u16 **pUsFile,
u8 **pUcFile, long word_length) u8 **pUcFile, long word_length)
{ {
int Status = 0;
int byte_length; int byte_length;
byte_length = word_length * 4; byte_length = word_length * 4;
@ -547,7 +546,7 @@ static int write_blk_fifo(struct ft1000_usb *ft1000dev, u16 **pUsFile,
*pUsFile = *pUsFile + (word_length << 1); *pUsFile = *pUsFile + (word_length << 1);
*pUcFile = *pUcFile + (word_length << 2); *pUcFile = *pUcFile + (word_length << 2);
return Status; return 0;
} }
static int scram_start_dwnld(struct ft1000_usb *ft1000dev, u16 *hshake, static int scram_start_dwnld(struct ft1000_usb *ft1000dev, u16 *hshake,