redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net/sunrpc: fix useless comparison in proc_do_xprt() 

In the original code, the "if (*lenp < 0)" check didn't work because
"*lenp" is unsigned.  Fortunately, the memory_read_from_buffer() call
will never fail in this context so it doesn't affect runtime.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
zero-sugar-mainline-defconfig
Dan Carpenter 2020-11-06 15:50:39 -05:00 committed by J. Bruce Fields
parent d435c05ab0
commit ae2975046d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/sunrpc/sysctl.c
View File

@ -63,19 +63,20 @@ static int proc_do_xprt(struct ctl_table *table, int write,
void *buffer, size_t *lenp, loff_t *ppos)
{
char tmpbuf[256];
size_t len;
ssize_t len;
if (write || *ppos) {
*lenp = 0;
return 0;
}
len = svc_print_xprts(tmpbuf, sizeof(tmpbuf));
*lenp = memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);
len = memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);
if (*lenp < 0) {
if (len < 0) {
*lenp = 0;
return -EINVAL;
}
*lenp = len;
return 0;
}