redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

iommu/sun50i: Fix return value check in sun50i_iommu_probe()

Browse source 
In case of error, the function devm_platform_ioremap_resource() returns
ERR_PTR() not NULL. The NULL test in the return value check must be
replaced with IS_ERR().

Fixes: 4100b8c229 ("iommu: Add Allwinner H6 IOMMU driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20200519091857.134170-1-weiyongjun1@huawei.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Wei Yongjun 2020-05-19 09:18:57 +00:00 committed by Joerg Roedel
parent 38b91f810b
commit ae7d292324
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/iommu/sun50i-iommu.c
View file

@ -941,7 +941,7 @@ static int sun50i_iommu_probe(struct platform_device *pdev)
}
iommu->base = devm_platform_ioremap_resource(pdev, 0);
if (!iommu->base) {
if (IS_ERR(iommu->base)) {
ret = PTR_ERR(iommu->base);
goto err_free_group;
}