redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

spi: spi-mem: Fix inverted logic in op sanity check 

On r8a7791/koelsch:

    m25p80 spi0.0: error -22 reading 9f
    m25p80: probe of spi0.0 failed with error -22

Apparently the logic in spi_mem_check_op() is wrong, rejecting the
spi-mem operation if any buswidth is valid, instead of invalid.

Fixes: 380583227c ("spi: spi-mem: Add extra sanity checks on the op param")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Geert Uytterhoeven 2018-09-25 11:46:55 +02:00 committed by Mark Brown
parent 73569a5095
commit aea3877e24
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/spi/spi-mem.c
View File

@ -169,10 +169,10 @@ static int spi_mem_check_op(const struct spi_mem_op *op)
(op->data.nbytes && !op->data.buswidth))
return -EINVAL;
if (spi_mem_buswidth_is_valid(op->cmd.buswidth) ||
spi_mem_buswidth_is_valid(op->addr.buswidth) ||
spi_mem_buswidth_is_valid(op->dummy.buswidth) ||
spi_mem_buswidth_is_valid(op->data.buswidth))
if (!spi_mem_buswidth_is_valid(op->cmd.buswidth) ||
!spi_mem_buswidth_is_valid(op->addr.buswidth) ||
!spi_mem_buswidth_is_valid(op->dummy.buswidth) ||
!spi_mem_buswidth_is_valid(op->data.buswidth))
return -EINVAL;
return 0;