redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

iio: lsiio: fix error code handling error 

commit acf50b3586
"tools:iio:lsiio: add error handling"
introduced error handling of errors returned from
read_sysfs_string(), but with a simple if (retval),
missing the fact that these functions return a positive
value if the read was successful.

As a result lsiio regresses and does not show any
devices on my filesystem. Fix this by checking for
only negative error codes.

Cc: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
hifive-unleashed-5.1
Linus Walleij 2015-08-04 16:21:49 +02:00 committed by Jonathan Cameron
parent 06d2f6ca5a
commit af255cd562
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/iio/lsiio.c
View File

@ -69,7 +69,7 @@ static int dump_one_device(const char *dev_dir_name)
return -EINVAL;
ret = read_sysfs_string("name", dev_dir_name, name);
if (ret)
if (ret < 0)
return ret;
printf("Device %03d: %s\n", dev_idx, name);
@ -92,7 +92,7 @@ static int dump_one_trigger(const char *dev_dir_name)
return -EINVAL;
ret = read_sysfs_string("name", dev_dir_name, name);
if (ret)
if (ret < 0)
return ret;
printf("Trigger %03d: %s\n", dev_idx, name);