redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

leds: netxbig: Add of_node_put() in netxbig_leds_get_of_pdata() 

The variable gpio_ext_np in the function netxbig_leds_get_of_pdata takes
the value returned by of_parse_phandle; hence, it must be put in order
to prevent a memory leak. Add an of_node_put for gpio_ext_np before a
return statement, and move a pre-existing of_node_put statement to right
after the last usage of this variable.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
alistair/sunxi64-5.4-dsi
Nishka Dasgupta 2019-07-29 12:23:56 +05:30 committed by Jacek Anaszewski
parent 156189a6d7
commit af7b650549
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/leds/leds-netxbig.c
View File

@ -428,12 +428,14 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
}
gpio_ext = devm_kzalloc(dev, sizeof(*gpio_ext), GFP_KERNEL);
if (!gpio_ext)
if (!gpio_ext) {
of_node_put(gpio_ext_np);
return -ENOMEM;
}
ret = gpio_ext_get_of_pdata(dev, gpio_ext_np, gpio_ext);
of_node_put(gpio_ext_np);
if (ret)
return ret;
of_node_put(gpio_ext_np);
pdata->gpio_ext = gpio_ext;
/* Timers (optional) */