redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] staging: lirc_serial: Do not assume error codes returned by request_irq()

Browse source 
lirc_serial_probe() must fail if request_irq() returns an error, even if
it isn't EBUSY or EINVAL,

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Ben Hutchings 2011-11-16 01:54:04 -03:00 committed by Mauro Carvalho Chehab
parent 9b98d60679
commit affc9a0d59
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
drivers/staging/media/lirc/lirc_serial.c
View file

@ -843,18 +843,15 @@ static int __devinit lirc_serial_probe(struct platform_device *dev)
result = request_irq(irq, irq_handler, result = request_irq(irq, irq_handler,
(share_irq ? IRQF_SHARED : 0), (share_irq ? IRQF_SHARED : 0),
LIRC_DRIVER_NAME, (void *)&hardware); LIRC_DRIVER_NAME, (void *)&hardware);
if (result < 0) {
switch (result) { if (result == -EBUSY)
case -EBUSY: printk(KERN_ERR LIRC_DRIVER_NAME ": IRQ %d busy\n",
printk(KERN_ERR LIRC_DRIVER_NAME ": IRQ %d busy\n", irq); irq);
return -EBUSY; else if (result == -EINVAL)
case -EINVAL: printk(KERN_ERR LIRC_DRIVER_NAME
printk(KERN_ERR LIRC_DRIVER_NAME ": Bad irq number or handler\n");
": Bad irq number or handler\n"); return result;
return -EINVAL; }
default:
break;
};
/* Reserve io region. */ /* Reserve io region. */
/* /*