[SCSI] bnx2fc: adjust duplicate test
Delete successive tests to the same location. The code tested the result of a previous allocation, that itself was already tested. It is changed to test the result of the most recent allocation. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @s exists@ local idexpression y; expression x,e; @@ *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) { ... when forall return ...; } ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\) when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\) *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) { ... when forall return ...; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
parent
72da7bcd68
commit
b0d5e15cc4
|
@ -654,7 +654,7 @@ int bnx2fc_init_mp_req(struct bnx2fc_cmd *io_req)
|
|||
mp_req->mp_resp_bd = dma_alloc_coherent(&hba->pcidev->dev, sz,
|
||||
&mp_req->mp_resp_bd_dma,
|
||||
GFP_ATOMIC);
|
||||
if (!mp_req->mp_req_bd) {
|
||||
if (!mp_req->mp_resp_bd) {
|
||||
printk(KERN_ERR PFX "unable to alloc MP resp bd\n");
|
||||
bnx2fc_free_mp_resc(io_req);
|
||||
return FAILED;
|
||||
|
|
Loading…
Reference in a new issue