redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

serial: 8250_dma: no need to set tx_err twice 

In the serial8250_tx_dma() the tx_err flag is set in case of error. Thus, there
is no need to repeat this in __dma_tx_complete().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Andy Shevchenko 2014-11-06 13:28:17 +02:00 committed by Greg Kroah-Hartman
parent 2dc98946d4
commit b1835d238a
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/8250/8250_dma.c
View File

@ -39,7 +39,6 @@ static void __dma_tx_complete(void *param)
ret = serial8250_tx_dma(p);
if (ret) {
dma->tx_err = 1;
p->ier |= UART_IER_THRI;
serial_port_out(&p->port, UART_IER, p->ier);
}
@ -93,7 +92,6 @@ int serial8250_tx_dma(struct uart_8250_port *p)
}
dma->tx_running = 1;
desc->callback = __dma_tx_complete;
desc->callback_param = p;