redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

spi: txx9: fix reference leak to master in txx9spi_remove() 

Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.

Fixes: 2fe7e4add3 ('spi: txx9: use devm_spi_register_master()')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
hifive-unleashed-5.1
Wei Yongjun 2013-11-15 15:49:29 +08:00 committed by Mark Brown
parent 82f85cf98f
commit b38f87ec50
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/spi/spi-txx9.c
View File

@ -425,7 +425,7 @@ exit:
static int txx9spi_remove(struct platform_device *dev)
{
struct spi_master *master = spi_master_get(platform_get_drvdata(dev));
struct spi_master *master = platform_get_drvdata(dev);
struct txx9spi *c = spi_master_get_devdata(master);
destroy_workqueue(c->workqueue);