Fix remaining big endian issue of hfcmulti

The driver was not so bad at big endian at all, only the optimised fifo
read/write functions need a fix, with this fix the driver works on
a pegasus PPC machine.

Signed-off-by: Karsten Keil <kkeil@suse.de>
This commit is contained in:
Karsten Keil 2008-08-02 16:35:53 +02:00
parent ff4cc1de24
commit b3e0aeeb7e

View file

@ -140,7 +140,7 @@
* #define HFC_REGISTER_DEBUG * #define HFC_REGISTER_DEBUG
*/ */
static const char *hfcmulti_revision = "2.00"; static const char *hfcmulti_revision = "2.01";
#include <linux/module.h> #include <linux/module.h>
#include <linux/pci.h> #include <linux/pci.h>
@ -427,12 +427,12 @@ write_fifo_regio(struct hfc_multi *hc, u_char *data, int len)
{ {
outb(A_FIFO_DATA0, (hc->pci_iobase)+4); outb(A_FIFO_DATA0, (hc->pci_iobase)+4);
while (len>>2) { while (len>>2) {
outl(*(u32 *)data, hc->pci_iobase); outl(cpu_to_le32(*(u32 *)data), hc->pci_iobase);
data += 4; data += 4;
len -= 4; len -= 4;
} }
while (len>>1) { while (len>>1) {
outw(*(u16 *)data, hc->pci_iobase); outw(cpu_to_le16(*(u16 *)data), hc->pci_iobase);
data += 2; data += 2;
len -= 2; len -= 2;
} }
@ -447,17 +447,19 @@ void
write_fifo_pcimem(struct hfc_multi *hc, u_char *data, int len) write_fifo_pcimem(struct hfc_multi *hc, u_char *data, int len)
{ {
while (len>>2) { while (len>>2) {
writel(*(u32 *)data, (hc->pci_membase)+A_FIFO_DATA0); writel(cpu_to_le32(*(u32 *)data),
hc->pci_membase + A_FIFO_DATA0);
data += 4; data += 4;
len -= 4; len -= 4;
} }
while (len>>1) { while (len>>1) {
writew(*(u16 *)data, (hc->pci_membase)+A_FIFO_DATA0); writew(cpu_to_le16(*(u16 *)data),
hc->pci_membase + A_FIFO_DATA0);
data += 2; data += 2;
len -= 2; len -= 2;
} }
while (len) { while (len) {
writeb(*data, (hc->pci_membase)+A_FIFO_DATA0); writeb(*data, hc->pci_membase + A_FIFO_DATA0);
data++; data++;
len--; len--;
} }
@ -468,12 +470,12 @@ read_fifo_regio(struct hfc_multi *hc, u_char *data, int len)
{ {
outb(A_FIFO_DATA0, (hc->pci_iobase)+4); outb(A_FIFO_DATA0, (hc->pci_iobase)+4);
while (len>>2) { while (len>>2) {
*(u32 *)data = inl(hc->pci_iobase); *(u32 *)data = le32_to_cpu(inl(hc->pci_iobase));
data += 4; data += 4;
len -= 4; len -= 4;
} }
while (len>>1) { while (len>>1) {
*(u16 *)data = inw(hc->pci_iobase); *(u16 *)data = le16_to_cpu(inw(hc->pci_iobase));
data += 2; data += 2;
len -= 2; len -= 2;
} }
@ -490,18 +492,18 @@ read_fifo_pcimem(struct hfc_multi *hc, u_char *data, int len)
{ {
while (len>>2) { while (len>>2) {
*(u32 *)data = *(u32 *)data =
readl((hc->pci_membase)+A_FIFO_DATA0); le32_to_cpu(readl(hc->pci_membase + A_FIFO_DATA0));
data += 4; data += 4;
len -= 4; len -= 4;
} }
while (len>>1) { while (len>>1) {
*(u16 *)data = *(u16 *)data =
readw((hc->pci_membase)+A_FIFO_DATA0); le16_to_cpu(readw(hc->pci_membase + A_FIFO_DATA0));
data += 2; data += 2;
len -= 2; len -= 2;
} }
while (len) { while (len) {
*data = readb((hc->pci_membase)+A_FIFO_DATA0); *data = readb(hc->pci_membase + A_FIFO_DATA0);
data++; data++;
len--; len--;
} }
@ -5251,9 +5253,6 @@ HFCmulti_init(void)
if (debug & DEBUG_HFCMULTI_INIT) if (debug & DEBUG_HFCMULTI_INIT)
printk(KERN_DEBUG "%s: init entered\n", __func__); printk(KERN_DEBUG "%s: init entered\n", __func__);
#ifdef __BIG_ENDIAN
#error "not running on big endian machines now"
#endif
hfc_interrupt = symbol_get(ztdummy_extern_interrupt); hfc_interrupt = symbol_get(ztdummy_extern_interrupt);
register_interrupt = symbol_get(ztdummy_register_interrupt); register_interrupt = symbol_get(ztdummy_register_interrupt);
unregister_interrupt = symbol_get(ztdummy_unregister_interrupt); unregister_interrupt = symbol_get(ztdummy_unregister_interrupt);