redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

printk: return -EINVAL if the message len is bigger than the buf size 

Just like what devkmsg_read() does, return -EINVAL if the message len is
bigger than the buf size, or it will trigger a segfault error.

Acked-by: Kay Sievers <kay@vrfy.org>
Acked-by: Fengguang Wu <wfg@linux.intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Yuanhan Liu 2012-06-16 12:40:55 +08:00 committed by Greg Kroah-Hartman
parent 4a77a5a06e
commit b56a39ac26
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/printk.c
View File

@ -880,7 +880,9 @@ static int syslog_print(char __user *buf, int size)
syslog_seq++;
raw_spin_unlock_irq(&logbuf_lock);
if (len > 0 && copy_to_user(buf, text, len))
if (len > size)
len = -EINVAL;
else if (len > 0 && copy_to_user(buf, text, len))
len = -EFAULT;
kfree(text);