redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: interface: fix interface_id attribute group 

All interfaces, regardless of type, should have an interface_id
attribute reflecting its position on the frame.

This has been reported to cause an assertion failure in libmoduleutil
for dummy modules.

Testing done: Verified that the attribute is present for registered
dummy interfaces.

Reported-by: Gjorgji Rosikopulos <grosikopulos@mm-sol.com>
Tested-by: Gjorgji Rosikopulos <grosikopulos@mm-sol.com>
Reviewed-by: Patrick Titiano <ptitiano@baylibre.com>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Johan Hovold 2016-07-21 12:48:57 +02:00 committed by Greg Kroah-Hartman
parent 10a24b7c09
commit b5d1d1282b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/greybus/interface.c
View File

@ -587,7 +587,6 @@ static struct attribute *interface_unipro_attrs[] = {
};
static struct attribute *interface_greybus_attrs[] = {
&dev_attr_interface_id.attr,
&dev_attr_vendor_id.attr,
&dev_attr_product_id.attr,
&dev_attr_serial_number.attr,
@ -603,6 +602,7 @@ static struct attribute *interface_power_attrs[] = {
};
static struct attribute *interface_common_attrs[] = {
&dev_attr_interface_id.attr,
&dev_attr_interface_type.attr,
NULL
};