redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c 

[ Upstream commit 95f59bf88b ]

This patch fixes the following warning:
=============================
WARNING: suspicious RCU usage
5.7.0-rc5-next-20200514-syzkaller #0 Not tainted
-----------------------------
drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!!

Since rtnl lock is held, pass this cond in list_for_each_entry_rcu().

Reported-by: syzbot+bb82cafc737c002d11ca@syzkaller.appspotmail.com
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
5.4-rM2-2.2.x-imx-squashed
Madhuparna Bhowmik 2020-05-14 19:41:15 +05:30 committed by Greg Kroah-Hartman
parent dfe417b456
commit b66de2d961
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/hamradio/bpqether.c
View File

@ -127,7 +127,8 @@ static inline struct net_device *bpq_get_ax25_dev(struct net_device *dev)
{
struct bpqdev *bpq;
list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list) {
list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list,
lockdep_rtnl_is_held()) {
if (bpq->ethdev == dev)
return bpq->axdev;
}