redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

usb: chipidea: remove unneeded NULL check

Browse source 
As reported by Dan Carpenter, there is a NULL check in udc_start() that
follows a dereference of the pointer that's being checked. However, at
that point udc pointer shouldn't ever be NULL and if it is, the dereference
should cause an oops.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alexander Shishkin 2012-06-29 17:48:49 +08:00 committed by Greg Kroah-Hartman
parent 3d97ff63f8
commit b7283d5a04
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/usb/chipidea/udc.c
View file

@ -1648,9 +1648,6 @@ static int udc_start(struct ci13xxx *udc)
struct device *dev = udc->dev;
int retval = 0;
if (!udc)
return -EINVAL;
spin_lock_init(&udc->lock);
udc->gadget.ops = &usb_gadget_ops;