redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

USB audio gadget: Un-inline generic_[gs]et_cmd

Browse source 
Those functions are used only used to fill the set/get members of
usb_audio_control. It doesn't make much sense to inline them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Laurent Pinchart 2009-06-21 23:21:55 +02:00 committed by Greg Kroah-Hartman
parent 512ad27d86
commit b95cd7ec3e
2 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/usb/gadget/f_audio.c
View file

@ -28,6 +28,9 @@ static int audio_buf_size = 48000;
module_param(audio_buf_size, int, S_IRUGO); module_param(audio_buf_size, int, S_IRUGO);
MODULE_PARM_DESC(audio_buf_size, "Audio buffer size"); MODULE_PARM_DESC(audio_buf_size, "Audio buffer size");
static int generic_set_cmd(struct usb_audio_control *con, u8 cmd, int value);
static int generic_get_cmd(struct usb_audio_control *con, u8 cmd);
/* /*
* DESCRIPTORS ... most are static, but strings and full * DESCRIPTORS ... most are static, but strings and full
* configuration descriptors are built on demand. * configuration descriptors are built on demand.
@ -632,6 +635,18 @@ f_audio_unbind(struct usb_configuration *c, struct usb_function *f)
/*-------------------------------------------------------------------------*/ /*-------------------------------------------------------------------------*/
static int generic_set_cmd(struct usb_audio_control *con, u8 cmd, int value)
{
con->data[cmd] = value;
return 0;
}
static int generic_get_cmd(struct usb_audio_control *con, u8 cmd)
{
return con->data[cmd];
}
/* Todo: add more control selecotor dynamically */ /* Todo: add more control selecotor dynamically */
int __init control_selector_init(struct f_audio *audio) int __init control_selector_init(struct f_audio *audio)
{ {

12
include/linux/usb/audio.h
View file

@ -285,18 +285,6 @@ struct usb_audio_control {
int (*get)(struct usb_audio_control *con, u8 cmd); int (*get)(struct usb_audio_control *con, u8 cmd);
}; };
static inline int generic_set_cmd(struct usb_audio_control *con, u8 cmd, int value)
{
con->data[cmd] = value;
return 0;
}
static inline int generic_get_cmd(struct usb_audio_control *con, u8 cmd)
{
return con->data[cmd];
}
struct usb_audio_control_selector { struct usb_audio_control_selector {
struct list_head list; struct list_head list;
struct list_head control; struct list_head control;