redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

thermal: rcar_gen3_thermal: Replace devm_add_action() followed by failure action with devm_add_action_or_reset() 

devm_add_action_or_reset() is introduced as a helper function which
internally calls devm_add_action(). If devm_add_action() fails
then it will execute the action mentioned and return the error code.
This reduce source code size (avoid writing the action twice)
and reduce the likelyhood of bugs.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
alistair/sunxi64-5.4-dsi
Fuqian Huang 2019-07-08 20:34:09 +08:00 committed by Zhang Rui
parent 9aee371313
commit b9cd1663fb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/thermal/rcar_gen3_thermal.c
View File

@ -443,9 +443,8 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
if (ret)
goto error_unregister;
ret = devm_add_action(dev, rcar_gen3_hwmon_action, zone);
ret = devm_add_action_or_reset(dev, rcar_gen3_hwmon_action, zone);
if (ret) {
rcar_gen3_hwmon_action(zone);
goto error_unregister;
}