redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

dm9601: Consolidate common parts of dm_write_*_async

Browse source 
dm_write_async and dm_write_reg_async are almost identical.
Move common functionality to dm_write_async_helper (saves ~256b).

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Peter Korsgaard 2007-11-15 11:10:12 +01:00 committed by David S. Miller
parent 9ce6cf2553
commit ba734f349d
1 changed files with 13 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
drivers/net/usb/dm9601.c
View file

@ -101,17 +101,16 @@ static void dm_write_async_callback(struct urb *urb)
usb_free_urb(urb); usb_free_urb(urb);
} }
static void dm_write_async(struct usbnet *dev, u8 reg, u16 length, void *data) static void dm_write_async_helper(struct usbnet *dev, u8 reg, u8 value,
u16 length, void *data)
{ {
struct usb_ctrlrequest *req; struct usb_ctrlrequest *req;
struct urb *urb; struct urb *urb;
int status; int status;
devdbg(dev, "dm_write_async() reg=0x%02x length=%d", reg, length);
urb = usb_alloc_urb(0, GFP_ATOMIC); urb = usb_alloc_urb(0, GFP_ATOMIC);
if (!urb) { if (!urb) {
deverr(dev, "Error allocating URB in dm_write_async!"); deverr(dev, "Error allocating URB in dm_write_async_helper!");
return; return;
} }
@ -123,8 +122,8 @@ static void dm_write_async(struct usbnet *dev, u8 reg, u16 length, void *data)
} }
req->bRequestType = USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE; req->bRequestType = USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE;
req->bRequest = DM_WRITE_REGS; req->bRequest = length ? DM_WRITE_REGS : DM_WRITE_REG;
req->wValue = 0; req->wValue = cpu_to_le16(value);
req->wIndex = cpu_to_le16(reg); req->wIndex = cpu_to_le16(reg);
req->wLength = cpu_to_le16(length); req->wLength = cpu_to_le16(length);
@ -142,45 +141,19 @@ static void dm_write_async(struct usbnet *dev, u8 reg, u16 length, void *data)
} }
} }
static void dm_write_async(struct usbnet *dev, u8 reg, u16 length, void *data)
{
devdbg(dev, "dm_write_async() reg=0x%02x length=%d", reg, length);
dm_write_async_helper(dev, reg, 0, length, data);
}
static void dm_write_reg_async(struct usbnet *dev, u8 reg, u8 value) static void dm_write_reg_async(struct usbnet *dev, u8 reg, u8 value)
{ {
struct usb_ctrlrequest *req;
struct urb *urb;
int status;
devdbg(dev, "dm_write_reg_async() reg=0x%02x value=0x%02x", devdbg(dev, "dm_write_reg_async() reg=0x%02x value=0x%02x",
reg, value); reg, value);
urb = usb_alloc_urb(0, GFP_ATOMIC); dm_write_async_helper(dev, reg, value, 0, NULL);
if (!urb) {
deverr(dev, "Error allocating URB in dm_write_async!");
return;
}
req = kmalloc(sizeof(struct usb_ctrlrequest), GFP_ATOMIC);
if (!req) {
deverr(dev, "Failed to allocate memory for control request");
usb_free_urb(urb);
return;
}
req->bRequestType = USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE;
req->bRequest = DM_WRITE_REG;
req->wValue = cpu_to_le16(value);
req->wIndex = cpu_to_le16(reg);
req->wLength = 0;
usb_fill_control_urb(urb, dev->udev,
usb_sndctrlpipe(dev->udev, 0),
(void *)req, NULL, 0, dm_write_async_callback, req);
status = usb_submit_urb(urb, GFP_ATOMIC);
if (status < 0) {
deverr(dev, "Error submitting the control message: status=%d",
status);
kfree(req);
usb_free_urb(urb);
}
} }
static int dm_read_shared_word(struct usbnet *dev, int phy, u8 reg, u16 *value) static int dm_read_shared_word(struct usbnet *dev, int phy, u8 reg, u16 *value)