redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: lustre: obdclass: genops: remove unneeded null test before free

Browse source 
Kfree can cope with a null argument, so drop null tests.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression ptr; @@

- if (ptr != NULL)
  kfree(ptr);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2015-05-01 21:37:55 +02:00 committed by Greg Kroah-Hartman
parent 6fa7cbab38
commit ba99a0aff2
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/staging/lustre/lustre/obdclass/genops.c
View file

@ -213,12 +213,9 @@ int class_register_type(struct obd_ops *dt_ops, struct md_ops *md_ops,
return 0;
failed:
if (type->typ_name != NULL)
kfree(type->typ_name);
if (type->typ_md_ops != NULL)
kfree(type->typ_md_ops);
if (type->typ_dt_ops != NULL)
kfree(type->typ_dt_ops);
kfree(type->typ_name);
kfree(type->typ_md_ops);
kfree(type->typ_dt_ops);
kfree(type);
return rc;
}
@ -253,10 +250,8 @@ int class_unregister_type(const char *name)
list_del(&type->typ_chain);
spin_unlock(&obd_types_lock);
kfree(type->typ_name);
if (type->typ_dt_ops != NULL)
kfree(type->typ_dt_ops);
if (type->typ_md_ops != NULL)
kfree(type->typ_md_ops);
kfree(type->typ_dt_ops);
kfree(type->typ_md_ops);
kfree(type);
return 0;
} /* class_unregister_type */