redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

platform/x86: wmi: Remove acpi_has_method() call 

acpi_has_method() is unnecessary within __query_block() and should be
removed to avoid extra work.

wc_status is initialized to AE_ERROR before the acpi_has_method() call.
acpi_has_method() and acpi_execute_simple_method() failing due to the
method not existing will result in the same outcome from __query_block().

Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
alistair/sunxi64-5.4-dsi
Kelsey Skunberg 2019-07-21 21:11:58 -06:00 committed by Andy Shevchenko
parent 5599e98fe0
commit bad9da86f9
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/platform/x86/wmi.c
View File

@ -340,9 +340,7 @@ static acpi_status __query_block(struct wmi_block *wblock, u8 instance,
* expensive, but have no corresponding WCxx method. So we
* should not fail if this happens.
*/
if (acpi_has_method(handle, wc_method))
wc_status = acpi_execute_simple_method(handle,
wc_method, 1);
wc_status = acpi_execute_simple_method(handle, wc_method, 1);
}
strcpy(method, "WQ");