perf c2c report: Add cacheline index entry
It's convenient to have an index for each cacheline to help discussions
about results over the phone.
Add new 'Index' and 'Num' fields in main and single cacheline tables.
$ perf c2c report
=================================================
Shared Data Cache Line Table
=================================================
#
# Total Lcl ----- LLC Load Hitm -----
# Index Cacheline records Hitm Total Lcl Rmt ...
# ..... .................. ....... ....... ....... ....... .......
#
0 0xffff880036233b40 1 11.11% 1 1 0
1 0xffff88009ccb2900 1 11.11% 1 1 0
2 0xffff8800b5b3bc40 7 11.11% 1 1 0
...
=================================================
Shared Cache Line Distribution Pareto
=================================================
#
# ----- HITM ----- -- Store Refs -- Data address
# Num Rmt Lcl L1 Hit L1 Miss Offset Pid ...
# ..... ....... ....... ....... ....... .................. .......
#
-------------------------------------------------------------
0 0 1 0 0 0xffff880036233b40
-------------------------------------------------------------
0.00% 100.00% 0.00% 0.00% 0x30 0
-------------------------------------------------------------
1 0 1 0 0 0xffff88009ccb2900
-------------------------------------------------------------
0.00% 100.00% 0.00% 0.00% 0x28 549
...
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-4dhfagaz57tvrfjbg8nd2h4u@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa
Arnaldo Carvalho de Melo
parent
25aa84e32d
commit
bb342daed8
|
|
@ -36,6 +36,7 @@ struct c2c_hist_entry {
|
|||
struct c2c_stats stats;
|
||||
unsigned long *cpuset;
|
||||
struct c2c_stats *node_stats;
|
||||
unsigned int cacheline_idx;
|
||||
|
||||
struct compute_stats cstats;
|
||||
|
||||
|
|
@ -1088,6 +1089,29 @@ cpucnt_entry(struct perf_hpp_fmt *fmt __maybe_unused, struct perf_hpp *hpp,
|
|||
return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
|
||||
}
|
||||
|
||||
static int
|
||||
cl_idx_entry(struct perf_hpp_fmt *fmt __maybe_unused, struct perf_hpp *hpp,
|
||||
struct hist_entry *he)
|
||||
{
|
||||
struct c2c_hist_entry *c2c_he;
|
||||
int width = c2c_width(fmt, hpp, he->hists);
|
||||
char buf[10];
|
||||
|
||||
c2c_he = container_of(he, struct c2c_hist_entry, he);
|
||||
|
||||
scnprintf(buf, 10, "%u", c2c_he->cacheline_idx);
|
||||
return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
|
||||
}
|
||||
|
||||
static int
|
||||
cl_idx_empty_entry(struct perf_hpp_fmt *fmt __maybe_unused, struct perf_hpp *hpp,
|
||||
struct hist_entry *he)
|
||||
{
|
||||
int width = c2c_width(fmt, hpp, he->hists);
|
||||
|
||||
return scnprintf(hpp->buf, hpp->size, "%*s", width, "");
|
||||
}
|
||||
|
||||
#define HEADER_LOW(__h) \
|
||||
{ \
|
||||
.line[1] = { \
|
||||
|
|
@ -1433,6 +1457,30 @@ static struct c2c_dimension dim_srcline = {
|
|||
.se = &sort_srcline,
|
||||
};
|
||||
|
||||
static struct c2c_dimension dim_dcacheline_idx = {
|
||||
.header = HEADER_LOW("Index"),
|
||||
.name = "cl_idx",
|
||||
.cmp = empty_cmp,
|
||||
.entry = cl_idx_entry,
|
||||
.width = 5,
|
||||
};
|
||||
|
||||
static struct c2c_dimension dim_dcacheline_num = {
|
||||
.header = HEADER_LOW("Num"),
|
||||
.name = "cl_num",
|
||||
.cmp = empty_cmp,
|
||||
.entry = cl_idx_entry,
|
||||
.width = 5,
|
||||
};
|
||||
|
||||
static struct c2c_dimension dim_dcacheline_num_empty = {
|
||||
.header = HEADER_LOW("Num"),
|
||||
.name = "cl_num_empty",
|
||||
.cmp = empty_cmp,
|
||||
.entry = cl_idx_empty_entry,
|
||||
.width = 5,
|
||||
};
|
||||
|
||||
static struct c2c_dimension *dimensions[] = {
|
||||
&dim_dcacheline,
|
||||
&dim_offset,
|
||||
|
|
@ -1472,6 +1520,9 @@ static struct c2c_dimension *dimensions[] = {
|
|||
&dim_mean_load,
|
||||
&dim_cpucnt,
|
||||
&dim_srcline,
|
||||
&dim_dcacheline_idx,
|
||||
&dim_dcacheline_num,
|
||||
&dim_dcacheline_num_empty,
|
||||
NULL,
|
||||
};
|
||||
|
||||
|
|
@ -1761,6 +1812,10 @@ static int resort_cl_cb(struct hist_entry *he)
|
|||
calc_width(he);
|
||||
|
||||
if (display && c2c_hists) {
|
||||
static unsigned int idx;
|
||||
|
||||
c2c_he->cacheline_idx = idx++;
|
||||
|
||||
c2c_hists__reinit(c2c_hists, c2c.cl_output, c2c.cl_resort);
|
||||
|
||||
hists__collapse_resort(&c2c_hists->hists, NULL);
|
||||
|
|
@ -1948,10 +2003,10 @@ static void print_cacheline(struct c2c_hists *c2c_hists,
|
|||
fprintf(out, "\n");
|
||||
}
|
||||
|
||||
fprintf(out, " ------------------------------------------------------\n");
|
||||
fprintf(out, " -------------------------------------------------------------\n");
|
||||
__hist_entry__snprintf(he_cl, &hpp, hpp_list);
|
||||
fprintf(out, "%s\n", bf);
|
||||
fprintf(out, " ------------------------------------------------------\n");
|
||||
fprintf(out, " -------------------------------------------------------------\n");
|
||||
|
||||
hists__fprintf(&c2c_hists->hists, false, 0, 0, 0, out, true);
|
||||
}
|
||||
|
|
@ -1964,6 +2019,7 @@ static void print_pareto(FILE *out)
|
|||
|
||||
perf_hpp_list__init(&hpp_list);
|
||||
ret = hpp_list__parse(&hpp_list,
|
||||
"cl_num,"
|
||||
"cl_rmt_hitm,"
|
||||
"cl_lcl_hitm,"
|
||||
"cl_stores_l1hit,"
|
||||
|
|
@ -2321,7 +2377,8 @@ static int build_cl_output(char *cl_sort)
|
|||
}
|
||||
|
||||
if (asprintf(&c2c.cl_output,
|
||||
"%s%s%s%s%s%s%s%s%s",
|
||||
"%s%s%s%s%s%s%s%s%s%s",
|
||||
c2c.use_stdio ? "cl_num_empty," : "",
|
||||
"percent_rmt_hitm,"
|
||||
"percent_lcl_hitm,"
|
||||
"percent_stores_l1hit,"
|
||||
|
|
@ -2470,6 +2527,7 @@ static int perf_c2c__report(int argc, const char **argv)
|
|||
}
|
||||
|
||||
c2c_hists__reinit(&c2c.hists,
|
||||
"cl_idx,"
|
||||
"dcacheline,"
|
||||
"tot_recs,"
|
||||
"percent_hitm,"
|
||||
|
|
|
|||
Loading…
Reference in a new issue