redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: fsl-dpaa2: ethsw: Introduce ethsw_port_dev_check()

Browse source 
ethsw currently uses an open-coded comparison of netdev_ops to determine
whether whether a device represents a front panel port. Wrap this into a
named function to simplify reuse.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Petr Machata 2018-11-22 23:29:18 +00:00 committed by David S. Miller
parent 2b239f6780
commit bb89680561
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/staging/fsl-dpaa2/ethsw/ethsw.c
View file

@ -972,6 +972,11 @@ static int port_bridge_leave(struct net_device *netdev)
return err;
}
static bool ethsw_port_dev_check(const struct net_device *netdev)
{
return netdev->netdev_ops == &ethsw_port_ops;
}
static int port_netdevice_event(struct notifier_block *unused,
unsigned long event, void *ptr)
{
@ -980,7 +985,7 @@ static int port_netdevice_event(struct notifier_block *unused,
struct net_device *upper_dev;
int err = 0;
if (netdev->netdev_ops != &ethsw_port_ops)
if (!ethsw_port_dev_check(netdev))
return NOTIFY_DONE;
/* Handle just upper dev link/unlink for the moment */