redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

rtc: ds1302: fix error check in set_time 

The set_time callback for rtc-ds1302 doesn't write clock registers
because the error check for the return value from spi_write_then_read()
is not correct.  spi_write_then_read() which returns zero on success.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Sergey Yanovich <ynvich@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
hifive-unleashed-5.1
Akinobu Mita 2016-04-10 23:59:23 +09:00 committed by Alexandre Belloni
parent 05a7f27a88
commit bc83a141b8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/rtc/rtc-ds1302.c
View File

@ -53,7 +53,7 @@ static int ds1302_rtc_set_time(struct device *dev, struct rtc_time *time)
status = spi_write_then_read(spi, buf, 2,
NULL, 0);
if (!status)
if (status)
return status;
/* Write registers starting at the first time/date address. */