redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

USB: typec: fsusb302: no need to check return value of debugfs_create_dir() 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Clean up the fsusb302 driver to not care if the root directory was
created, as the code should work properly either way.

Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Greg Kroah-Hartman 2018-05-31 13:08:54 +02:00
parent e15bea0f3f
commit bc9832c4a1
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/usb/typec/fusb302/fusb302.c
View File

@ -215,20 +215,15 @@ DEFINE_SHOW_ATTRIBUTE(fusb302_debug);
static struct dentry *rootdir;
static int fusb302_debugfs_init(struct fusb302_chip *chip)
static void fusb302_debugfs_init(struct fusb302_chip *chip)
{
mutex_init(&chip->logbuffer_lock);
if (!rootdir) {
if (!rootdir)
rootdir = debugfs_create_dir("fusb302", NULL);
if (!rootdir)
return -ENOMEM;
}
chip->dentry = debugfs_create_file(dev_name(chip->dev),
S_IFREG | 0444, rootdir,
chip, &fusb302_debug_fops);
return 0;
}
static void fusb302_debugfs_exit(struct fusb302_chip *chip)
@ -241,7 +236,7 @@ static void fusb302_debugfs_exit(struct fusb302_chip *chip)
static void fusb302_log(const struct fusb302_chip *chip,
const char *fmt, ...) { }
static int fusb302_debugfs_init(const struct fusb302_chip *chip) { return 0; }
static void fusb302_debugfs_init(const struct fusb302_chip *chip) { }
static void fusb302_debugfs_exit(const struct fusb302_chip *chip) { }
#endif
@ -1773,9 +1768,7 @@ static int fusb302_probe(struct i2c_client *client,
return -EPROBE_DEFER;
}
ret = fusb302_debugfs_init(chip);
if (ret < 0)
return ret;
fusb302_debugfs_init(chip);
chip->wq = create_singlethread_workqueue(dev_name(chip->dev));
if (!chip->wq) {