redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

hwmon: (s3c-hwmon) Ignore invalid divider settings 

Avoid registering channels that have zero divider settings in them, as this
will only lead to kernel OOPS from divide-by-zero when the sysfs entry is
read.

Signed-off-by: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
hifive-unleashed-5.1
Ben Dooks 2009-11-16 12:45:39 +01:00 committed by Jean Delvare
parent a9366e61b0
commit be4c23c93c
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/hwmon/s3c-hwmon.c
View File

@ -323,14 +323,21 @@ static int __devinit s3c_hwmon_probe(struct platform_device *dev)
}
for (i = 0; i < ARRAY_SIZE(pdata->in); i++) {
if (!pdata->in[i])
struct s3c24xx_adc_hwmon_incfg *cfg = pdata->in[i];
if (!cfg)
continue;
if (pdata->in[i]->mult >= 0x10000)
if (cfg->mult >= 0x10000)
dev_warn(&dev->dev,
"channel %d multiplier too large\n",
i);
if (cfg->divider == 0) {
dev_err(&dev->dev, "channel %d divider zero\n", i);
continue;
}
ret = s3c_hwmon_create_attr(&dev->dev, pdata->in[i],
&hwmon->attrs[i], i);
if (ret) {