redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

sound/oss/trident.c: fix incorrect test in trident_ac97_set() 

If count reaches zero, the loop ends, but the postfix decrement still
subtracts: testing for 'count == 0' will not work.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Reviewed-by: Ray Lee <ray-lk@madrabbit.org>
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
hifive-unleashed-5.1
Roel Kluin 2008-02-06 01:36:51 -08:00 committed by Linus Torvalds
parent 67a3b2b6ce
commit be6c28e62e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/oss/trident.c
View File

@ -2935,7 +2935,7 @@ trident_ac97_set(struct ac97_codec *codec, u8 reg, u16 val)
do {
if ((inw(TRID_REG(card, address)) & busy) == 0)
break;
} while (count--);
} while (--count);
data |= (mask | (reg & AC97_REG_ADDR));
@ -2996,7 +2996,7 @@ trident_ac97_get(struct ac97_codec *codec, u8 reg)
data = inl(TRID_REG(card, address));
if ((data & busy) == 0)
break;
} while (count--);
} while (--count);
spin_unlock_irqrestore(&card->lock, flags);
if (count == 0) {