redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

amdgpu/pp: slim down the pwr virus tables. 

This is what I'd call slightly overengineered, we waste 40k on
storing a value that is write or end, when we could just use the
register value to denote end.

Remove the virus command parameter, and save
   text	   data	    bss	    dec	    hex	filename
1412724	  17982	   1008	1431714	 15d8a2	../drm-next-build/drivers/gpu/drm/amd/amdgpu/amdgpu.o
1331332	  17982	   1008	1350322	 149ab2	../drm-next-build/drivers/gpu/drm/amd/amdgpu/amdgpu.o

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
hifive-unleashed-5.1
Dave Airlie 2017-09-28 14:48:38 +10:00 committed by Alex Deucher
parent 819c4b949d
commit bf3486fd0e
4 changed files with 20284 additions and 20324 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20500
drivers/gpu/drm/amd/powerplay/inc/fiji_pwrvirus.h
View File

File diff suppressed because it is too large Load Diff

20072
drivers/gpu/drm/amd/powerplay/inc/polaris10_pwrvirus.h
View File

File diff suppressed because it is too large Load Diff

18
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
View File

@ -166,25 +166,15 @@ static int fiji_setup_pwr_virus(struct pp_hwmgr *hwmgr)
uint32_t reg, data;
const PWR_Command_Table *pvirus = PwrVirusTable;
struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend);
for (i = 0; i < PWR_VIRUS_TABLE_SIZE; i++) {
switch (pvirus->command) {
case PwrCmdWrite:
reg = pvirus->reg;
data = pvirus->data;
reg = pvirus->reg;
data = pvirus->data;
if (reg != 0xffffffff)
cgs_write_register(hwmgr->device, reg, data);
break;
case PwrCmdEnd:
else {
result = 0;
break;
default:
pr_info("Table Exit with Invalid Command!");
smu_data->avfs.avfs_btc_status = AVFS_BTC_VIRUS_FAIL;
result = -EINVAL;
break;
}
pvirus++;
}

18
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
View File

@ -67,25 +67,15 @@ static int polaris10_setup_pwr_virus(struct pp_hwmgr *hwmgr)
uint32_t reg, data;
const PWR_Command_Table *pvirus = pwr_virus_table;
struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend);
for (i = 0; i < PWR_VIRUS_TABLE_SIZE; i++) {
switch (pvirus->command) {
case PwrCmdWrite:
reg = pvirus->reg;
data = pvirus->data;
reg = pvirus->reg;
data = pvirus->data;
if (reg != 0xffffffff) {
cgs_write_register(hwmgr->device, reg, data);
break;
case PwrCmdEnd:
} else {
result = 0;
break;
default:
pr_info("Table Exit with Invalid Command!");
smu_data->avfs.avfs_btc_status = AVFS_BTC_VIRUS_FAIL;
result = -EINVAL;
break;
}
pvirus++;
}