1
0
Fork 0

staging: lustre: a typedef for 'struct miscdevice'???

Come on, that's just silly...

Anyway, remove the typedef and fix up the initializer to use named
fields, otherwise bad things might happen in the future.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Greg Kroah-Hartman 2013-07-24 10:21:26 -07:00
parent 0f1c743b99
commit c0426cf7df
6 changed files with 7 additions and 26 deletions

View File

@ -124,11 +124,6 @@ void libcfs_sock_release(socket_t *sock);
/*
* libcfs pseudo device operations
*
* struct psdev_t and
* misc_register() and
* misc_deregister() are declared in
* libcfs/<os>/<os>-prim.h
*
* It's just draft now.
*/

View File

@ -78,20 +78,6 @@
#define NR_CPUS 1
#endif
/*
* cache
*/
/*
* IRQs
*/
/*
* Pseudo device register
*/
typedef struct miscdevice psdev_t;
/*
* Sysctl register
*/

View File

@ -176,8 +176,8 @@ static struct file_operations libcfs_fops = {
release : libcfs_psdev_release
};
psdev_t libcfs_dev = {
LNET_MINOR,
"lnet",
&libcfs_fops
struct miscdevice libcfs_dev = {
.minor = LNET_MINOR,
.name = "lnet",
.fops = &libcfs_fops,
};

View File

@ -365,7 +365,7 @@ MODULE_AUTHOR("Peter J. Braam <braam@clusterfs.com>");
MODULE_DESCRIPTION("Portals v3.1");
MODULE_LICENSE("GPL");
extern psdev_t libcfs_dev;
extern struct miscdevice libcfs_dev;
extern struct rw_semaphore cfs_tracefile_sem;
extern struct mutex cfs_trace_thread_mutex;
extern struct cfs_wi_sched *cfs_sched_rehash;

View File

@ -432,7 +432,7 @@ int class_handle_ioctl(unsigned int cmd, unsigned long arg)
RETURN(err);
} /* class_handle_ioctl */
extern psdev_t obd_psdev;
extern struct miscdevice obd_psdev;
#define OBD_INIT_CHECK
int obd_init_checks(void)

View File

@ -211,7 +211,7 @@ static struct file_operations obd_psdev_fops = {
};
/* modules setup */
psdev_t obd_psdev = {
struct miscdevice obd_psdev = {
.minor = OBD_DEV_MINOR,
.name = OBD_DEV_NAME,
.fops = &obd_psdev_fops,