ALSA: hdspm: Fix zero-division
HDSPM driver contains a code issuing zero-division potentially in system sample rate ctl code. This patch fixes it by not processing a zero or invalid rate value as a divisor, as well as excluding the invalid value to be passed via the given ctl element. Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>hifive-unleashed-5.1
parent
537e481362
commit
c1099c3294
|
@ -1601,6 +1601,9 @@ static void hdspm_set_dds_value(struct hdspm *hdspm, int rate)
|
||||||
{
|
{
|
||||||
u64 n;
|
u64 n;
|
||||||
|
|
||||||
|
if (snd_BUG_ON(rate <= 0))
|
||||||
|
return;
|
||||||
|
|
||||||
if (rate >= 112000)
|
if (rate >= 112000)
|
||||||
rate /= 4;
|
rate /= 4;
|
||||||
else if (rate >= 56000)
|
else if (rate >= 56000)
|
||||||
|
@ -2215,6 +2218,8 @@ static int hdspm_get_system_sample_rate(struct hdspm *hdspm)
|
||||||
} else {
|
} else {
|
||||||
/* slave mode, return external sample rate */
|
/* slave mode, return external sample rate */
|
||||||
rate = hdspm_external_sample_rate(hdspm);
|
rate = hdspm_external_sample_rate(hdspm);
|
||||||
|
if (!rate)
|
||||||
|
rate = hdspm->system_sample_rate;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2260,7 +2265,10 @@ static int snd_hdspm_put_system_sample_rate(struct snd_kcontrol *kcontrol,
|
||||||
ucontrol)
|
ucontrol)
|
||||||
{
|
{
|
||||||
struct hdspm *hdspm = snd_kcontrol_chip(kcontrol);
|
struct hdspm *hdspm = snd_kcontrol_chip(kcontrol);
|
||||||
|
int rate = ucontrol->value.integer.value[0];
|
||||||
|
|
||||||
|
if (rate < 27000 || rate > 207000)
|
||||||
|
return -EINVAL;
|
||||||
hdspm_set_dds_value(hdspm, ucontrol->value.integer.value[0]);
|
hdspm_set_dds_value(hdspm, ucontrol->value.integer.value[0]);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue