redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: vt6656: sparse fixes: iwctl_giwgenie use memcpy. 

extra is in kernel space use memcpy.

sparse warning
iwctl.c:1595:42: warning: incorrect type in argument 1 (different address spaces)
iwctl.c:1595:42:    expected void [noderef] <asn:1>*to
iwctl.c:1595:42:    got char *extra

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Malcolm Priestley 2014-01-13 16:25:51 +00:00 committed by Greg Kroah-Hartman
parent 9010a286d9
commit c1cd14974c
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/vt6656/iwctl.c
View File

@ -1591,13 +1591,11 @@ int iwctl_giwgenie(struct net_device *dev, struct iw_request_info *info,
wrq->length = 0;
if (pMgmt->wWPAIELen > 0) {
wrq->length = pMgmt->wWPAIELen;
if (pMgmt->wWPAIELen <= space) {
if (copy_to_user(extra, pMgmt->abyWPAIE, pMgmt->wWPAIELen)) {
ret = -EFAULT;
}
} else {
if (pMgmt->wWPAIELen <= space)
memcpy(extra, pMgmt->abyWPAIE, pMgmt->wWPAIELen);
else
ret = -E2BIG;
}
}
return ret;
}