redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: unisys: visorbus change -1 return values 

This patch changes the vague -1 return values to -EFAULT since
it would be the most appropriate, given that this error
would only occur in an unexpected bad offset field.
Resulting in a bad address.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Erik Arfvidson 2016-05-13 23:17:19 -04:00 committed by Greg Kroah-Hartman
parent ba78c4707c
commit c294ea31aa
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/unisys/visorbus/visorbus_main.c
View File

@ -876,10 +876,10 @@ write_vbus_chp_info(struct visorchannel *chan,
int off = sizeof(struct channel_header) + hdr_info->chp_info_offset;
if (hdr_info->chp_info_offset == 0)
return -1;
return -EFAULT;
if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
return -1;
return -EFAULT;
return 0;
}
@ -895,10 +895,10 @@ write_vbus_bus_info(struct visorchannel *chan,
int off = sizeof(struct channel_header) + hdr_info->bus_info_offset;
if (hdr_info->bus_info_offset == 0)
return -1;
return -EFAULT;
if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
return -1;
return -EFAULT;
return 0;
}
@ -915,10 +915,10 @@ write_vbus_dev_info(struct visorchannel *chan,
(hdr_info->device_info_struct_bytes * devix);
if (hdr_info->dev_info_offset == 0)
return -1;
return -EFAULT;
if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
return -1;
return -EFAULT;
return 0;
}