redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

pinctrl: artpec6: Fix return value check in artpec6_pmx_probe() 

In case of error, the function pinctrl_register() returns
ERR_PTR() not NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Wei Yongjun 2017-04-25 11:29:30 +00:00 committed by Linus Walleij
parent a5bf5fc060
commit c312c2c333
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/pinctrl-artpec6.c
View File

@ -937,9 +937,9 @@ static int artpec6_pmx_probe(struct platform_device *pdev)
pmx->num_pin_groups = ARRAY_SIZE(artpec6_pin_groups);
pmx->pctl = pinctrl_register(&artpec6_desc, &pdev->dev, pmx);
if (!pmx->pctl) {
if (IS_ERR(pmx->pctl)) {
dev_err(&pdev->dev, "could not register pinctrl driver\n");
return -EINVAL;
return PTR_ERR(pmx->pctl);
}
platform_set_drvdata(pdev, pmx);