redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[SCSI] libfc: discovery restart sequence error fix

Browse source 
When an RSCN is received during fabric discovery, it restarts.
After the restart, disc->seq_count was incremented, so when
the first frame was received, it was considered "out of sequence".
That left the state disc->active, preventing further discoveries.

Change to advance the sequence count before parsing, so that it
won't be changed after a potential restart.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
Joe Eykholt 2009-08-25 14:02:17 -07:00 committed by James Bottomley
parent 0f6c614987
commit c356afd486
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/scsi/libfc/fc_disc.c
View file

@ -629,11 +629,10 @@ static void fc_disc_gpn_ft_resp(struct fc_seq *sp, struct fc_frame *fp,
seq_cnt, disc->seq_count, fr_sof(fp), fr_eof(fp)); seq_cnt, disc->seq_count, fr_sof(fp), fr_eof(fp));
} }
if (buf) { if (buf) {
disc->seq_count++;
error = fc_disc_gpn_ft_parse(disc, buf, len); error = fc_disc_gpn_ft_parse(disc, buf, len);
if (error) if (error)
fc_disc_error(disc, fp); fc_disc_error(disc, fp);
else
disc->seq_count++;
} }
fc_frame_free(fp); fc_frame_free(fp);