redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: manifest: use bundle's embedded interface pointer 

An initialized bundle structure contains a pointer to its
interface.  Because of this there's no need to provide
the interface pointer to gb_manifest_parse_cports().  This
also precludes the possibility of passing a bad interface
pointer.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Alex Elder 2015-06-09 17:42:54 -05:00 committed by Greg Kroah-Hartman
parent d393c98f11
commit c46839d1cc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/greybus/manifest.c
View File

@ -198,9 +198,9 @@ static char *gb_string_get(struct gb_interface *intf, u8 string_id)
* them. Returns the number of cports set up for the bundle, or 0
* if there is an error.
*/
static u32 gb_manifest_parse_cports(struct gb_interface *intf,
struct gb_bundle *bundle)
static u32 gb_manifest_parse_cports(struct gb_bundle *bundle)
{
struct gb_interface *intf = bundle->intf;
u32 count = 0;
while (true) {
@ -270,7 +270,7 @@ static u32 gb_manifest_parse_bundles(struct gb_interface *intf)
return 0; /* Error */
/* Now go set up this bundle's functions and cports */
if (!gb_manifest_parse_cports(intf, bundle))
if (!gb_manifest_parse_cports(bundle))
return 0; /* Error parsing cports */
count++;