brcmfmac: remove 'always false' condition from brcmf_c_mkiovar_bsscfg
The parameter buflen is unsigned so the condition buflen < 0 is always false. The patch fixes the if statement checking the buffer length. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by: Hante Meuleman <meuleman@broadcom.com> Signed-off-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
3cb91f5335
commit
c5b057b55f
|
@ -106,7 +106,7 @@ brcmf_c_mkiovar_bsscfg(char *name, char *data, uint datalen,
|
|||
namelen = (u32) strlen(name) + 1; /* lengh of iovar name + null */
|
||||
iolen = prefixlen + namelen + sizeof(bssidx_le) + datalen;
|
||||
|
||||
if (buflen < 0 || iolen > (u32)buflen) {
|
||||
if ((u32)buflen < iolen) {
|
||||
brcmf_dbg(ERROR, "buffer is too short\n");
|
||||
return 0;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue