redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

mailbox: always wait in mbox_send_message for blocking Tx mode 

There exists a race when msg_submit return immediately as there was an
active request being processed which may have completed just before it's
checked again in mbox_send_message. This will result in return to the
caller without waiting in mbox_send_message even when it's blocking Tx.

This patch fixes the issue by waiting for the completion always if Tx
is in blocking mode.

Fixes: 2b6d83e2b8 ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
hifive-unleashed-5.1
Sudeep Holla 2017-03-21 11:30:14 +00:00 committed by Jassi Brar
parent 73874913d5
commit c61b781ee0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mailbox/mailbox.c
View File

@ -260,7 +260,7 @@ int mbox_send_message(struct mbox_chan *chan, void *mssg)
msg_submit(chan);
if (chan->cl->tx_block && chan->active_req) {
if (chan->cl->tx_block) {
unsigned long wait;
int ret;