From c6826ad8a49f1230dcbc45dac26b54d492b13280 Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 23 Nov 2018 16:57:22 +0900 Subject: [PATCH] modpost: merge module iterations Probably, this is just a matter of the order of error/warning messages. Merge the two for-loops. Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index eedc2742dc8e..963a0b69b9a3 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2496,12 +2496,6 @@ int main(int argc, char **argv) if (files_source) read_symbols_from_files(files_source); - for (mod = modules; mod; mod = mod->next) { - if (mod->skip) - continue; - check_exports(mod); - } - err = 0; for (mod = modules; mod; mod = mod->next) { @@ -2513,6 +2507,7 @@ int main(int argc, char **argv) buf.pos = 0; err |= check_modname_len(mod); + check_exports(mod); add_header(&buf, mod); add_intree_flag(&buf, !external_module); add_retpoline(&buf);