redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

sound: oss: Use setup_timer and mod_timer. 

The function setup_timer combines the initialization of a timer with the
initialization of the timer's function and data fields. The mulitiline
code for timer initialization is now replaced with function setup_timer.

Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
   active timer (if the timer is inactive it will be activated).

Use setup_timer() and mod_timer() to setup and arm a timer, making the
code compact and aid readablity.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
hifive-unleashed-5.1
Muhammad Falak R Wani 2016-05-15 16:26:51 +05:30 committed by Takashi Iwai
parent 6971ce4134
commit c7c5856b6f
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/oss/waveartist.c
View File

@ -1414,11 +1414,9 @@ attach_waveartist(struct address_info *hw, const struct waveartist_mixer_info *m
else {
#ifdef CONFIG_ARCH_NETWINDER
if (machine_is_netwinder()) {
init_timer(&vnc_timer);
vnc_timer.function = vnc_slider_tick;
vnc_timer.expires = jiffies;
vnc_timer.data = nr_waveartist_devs;
add_timer(&vnc_timer);
setup_timer(&vnc_timer, vnc_slider_tick,
nr_waveartist_devs);
mod_timer(&vnc_timer, jiffies);
vnc_configure_mixer(devc, 0);