redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

net/dec: Make __de_get_link_ksettings return void

Browse source 
Make return value void since function never return meaningfull value

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
yuval.shaia@oracle.com 2017-06-04 20:08:51 +03:00 committed by David S. Miller
parent 8ec1507dc9
commit c7c6b8715a
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/net/ethernet/dec/tulip/de2104x.c
View file

@ -1483,8 +1483,8 @@ static void __de_get_regs(struct de_private *de, u8 *buf)
de_rx_missed(de, rbuf[8]);
}
static int __de_get_link_ksettings(struct de_private *de,
struct ethtool_link_ksettings *cmd)
static void __de_get_link_ksettings(struct de_private *de,
struct ethtool_link_ksettings *cmd)
{
ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
de->media_supported);
@ -1517,8 +1517,6 @@ static int __de_get_link_ksettings(struct de_private *de,
cmd->base.autoneg = AUTONEG_ENABLE;
/* ignore maxtxpkt, maxrxpkt for now */
return 0;
}
static int __de_set_link_ksettings(struct de_private *de,
@ -1615,13 +1613,12 @@ static int de_get_link_ksettings(struct net_device *dev,
struct ethtool_link_ksettings *cmd)
{
struct de_private *de = netdev_priv(dev);
int rc;
spin_lock_irq(&de->lock);
rc = __de_get_link_ksettings(de, cmd);
__de_get_link_ksettings(de, cmd);
spin_unlock_irq(&de->lock);
return rc;
return 0;
}
static int de_set_link_ksettings(struct net_device *dev,