redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

net/fec: replace hardcoded irq num with macro

Browse source 
Don't use hardcoded irq num and replace it with
FEC_IRQ_NUM macro.

Signed-off-by: Xiao Jiang <jgq516@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Xiao Jiang 2011-09-29 02:15:56 +00:00 committed by David S. Miller
parent 2e11437427
commit c7c83d1c95
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/net/ethernet/freescale/fec.c
View file

@ -177,6 +177,8 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
#define PKT_MINBUF_SIZE 64 #define PKT_MINBUF_SIZE 64
#define PKT_MAXBLR_SIZE 1520 #define PKT_MAXBLR_SIZE 1520
/* This device has up to three irqs on some platforms */
#define FEC_IRQ_NUM 3
/* /*
* The 5270/5271/5280/5282/532x RX control register also contains maximum frame * The 5270/5271/5280/5282/532x RX control register also contains maximum frame
@ -1540,8 +1542,7 @@ fec_probe(struct platform_device *pdev)
fec_reset_phy(pdev); fec_reset_phy(pdev);
/* This device has up to three irqs on some platforms */ for (i = 0; i < FEC_IRQ_NUM; i++) {
for (i = 0; i < 3; i++) {
irq = platform_get_irq(pdev, i); irq = platform_get_irq(pdev, i);
if (i && irq < 0) if (i && irq < 0)
break; break;
@ -1586,7 +1587,7 @@ failed_init:
clk_disable(fep->clk); clk_disable(fep->clk);
clk_put(fep->clk); clk_put(fep->clk);
failed_clk: failed_clk:
for (i = 0; i < 3; i++) { for (i = 0; i < FEC_IRQ_NUM; i++) {
irq = platform_get_irq(pdev, i); irq = platform_get_irq(pdev, i);
if (irq > 0) if (irq > 0)
free_irq(irq, ndev); free_irq(irq, ndev);