redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

OMAPFB: remove silly loop in fb2display()

Browse source 
fb2display() has a for loop which always returns at the first iteration.
Replace the loop with a simple if.

This removes the smatch warning:

drivers/video/omap2/omapfb/omapfb.h:153 fb2display() info: loop could be
replaced with if statement.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Tomi Valkeinen 2012-12-13 12:17:08 +02:00
parent fa0c5e7129
commit c7e1eae537
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/video/omap2/omapfb/omapfb.h
View file

@ -144,16 +144,16 @@ int omapfb_set_update_mode(struct fb_info *fbi, enum omapfb_update_mode mode);
static inline struct omap_dss_device *fb2display(struct fb_info *fbi)
{
struct omapfb_info *ofbi = FB2OFB(fbi);
int i;
struct omap_overlay *ovl;
/* XXX: returns the display connected to first attached overlay */
for (i = 0; i < ofbi->num_overlays; i++) {
struct omap_overlay *ovl = ofbi->overlays[i];
return ovl->get_device(ovl);
}
if (ofbi->num_overlays == 0)
return NULL;
return NULL;
ovl = ofbi->overlays[0];
return ovl->get_device(ovl);
}
static inline struct omapfb_display_data *get_display_data(