redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

netdevsim: Change dummy reporter auto recover default

Browse source 
Health reporters should be registered with auto recover set to true.
Align dummy reporter behaviour with that, as in later patch the option to
set auto recover behaviour will be removed.

In addition, align netdevsim selftest to the new default value.

Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eran Ben Elisha 2020-03-29 14:05:53 +03:00 committed by David S. Miller
parent 62582a7ee7
commit c7f0d4c898
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/netdevsim/health.c
View file

@ -278,7 +278,7 @@ int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink)
health->dummy_reporter =
devlink_health_reporter_create(devlink,
&nsim_dev_dummy_reporter_ops,
0, false, health);
0, true, health);
if (IS_ERR(health->dummy_reporter)) {
err = PTR_ERR(health->dummy_reporter);
goto err_empty_reporter_destroy;

5
tools/testing/selftests/drivers/net/netdevsim/devlink.sh
View file

@ -377,6 +377,11 @@ dummy_reporter_test()
{
RET=0
check_reporter_info dummy healthy 0 0 0 true
devlink health set $DL_HANDLE reporter dummy auto_recover false
check_err $? "Failed to dummy reporter auto_recover option"
check_reporter_info dummy healthy 0 0 0 false
local BREAK_MSG="foo bar"