redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

pinctrl: meson: use gpio-ranges from DT 

When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges
is needed when gpiochip_add_data() is called but in the current implementation
the ranges are added from the driver afterwards.

A simple solution is to rely on the DR gpio-ranges attribute and remove the
call to gpiochip_add_pin_range().

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Neil Armstrong 2017-03-23 17:27:28 +01:00 committed by Linus Walleij
parent 5fb7edb38d
commit c7fc5fbafa
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/pinctrl/meson/pinctrl-meson.c
View File

@ -555,22 +555,10 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
if (ret) {
dev_err(pc->dev, "can't add gpio chip %s\n",
pc->data->name);
goto fail;
}
ret = gpiochip_add_pin_range(&pc->chip, dev_name(pc->dev),
0, pc->data->pin_base,
pc->chip.ngpio);
if (ret) {
dev_err(pc->dev, "can't add pin range\n");
goto fail;
return ret;
}
return 0;
fail:
gpiochip_remove(&pc->chip);
return ret;
}
static struct regmap_config meson_regmap_config = {