redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/radeon: fixup refcounts in radeon dumb create ioctl.

Browse source 
This was using old gem refcounting methods, fix it to be the same
as the normal create ioctl.

Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Dave Airlie 2011-03-17 13:58:34 +10:00
parent a3a88a668f
commit c87a8d8dcd
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/gpu/drm/radeon/radeon_gem.c
View file

@ -358,6 +358,7 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,
{ {
struct radeon_device *rdev = dev->dev_private; struct radeon_device *rdev = dev->dev_private;
struct drm_gem_object *gobj; struct drm_gem_object *gobj;
uint32_t handle;
int r; int r;
args->pitch = radeon_align_pitch(rdev, args->width, args->bpp, 0) * ((args->bpp + 1) / 8); args->pitch = radeon_align_pitch(rdev, args->width, args->bpp, 0) * ((args->bpp + 1) / 8);
@ -371,12 +372,13 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,
if (r) if (r)
return -ENOMEM; return -ENOMEM;
r = drm_gem_handle_create(file_priv, gobj, &args->handle); r = drm_gem_handle_create(file_priv, gobj, &handle);
/* drop reference from allocate - handle holds it now */
drm_gem_object_unreference_unlocked(gobj);
if (r) { if (r) {
drm_gem_object_unreference_unlocked(gobj);
return r; return r;
} }
drm_gem_object_handle_unreference_unlocked(gobj); args->handle = handle;
return 0; return 0;
} }