redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net_failover: fixed rollback in net_failover_open() 

[ Upstream commit e8224bfe77 ]

found by smatch:
drivers/net/net_failover.c:65 net_failover_open() error:
 we previously assumed 'primary_dev' could be null (see line 43)

Fixes: cfc80d9a11 ("net: Introduce net_failover driver")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5.4-rM2-2.2.x-imx-squashed
Vasily Averin 2020-06-02 15:55:26 +03:00 committed by Greg Kroah-Hartman
parent 5ab453bb7b
commit c8e374ee60
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/net_failover.c
View File

@ -61,7 +61,8 @@ static int net_failover_open(struct net_device *dev)
return 0;
err_standby_open:
dev_close(primary_dev);
if (primary_dev)
dev_close(primary_dev);
err_primary_open:
netif_tx_disable(dev);
return err;