usb: gadget: s3c-hsotg.c: fix error return code
Convert a 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret != 0\|ret < 0\) || ...) { ... return ...; } | ret = 0 ) ... when != ret = e1 *x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...); ... when != x = e2 when != ret = e3 *if (x == NULL || ...) { ... when != ret = e4 * return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
parent
0416e494ce
commit
c8e6507bde
|
@ -3599,6 +3599,7 @@ static int __devinit s3c_hsotg_probe(struct platform_device *pdev)
|
|||
|
||||
if (hsotg->num_of_eps == 0) {
|
||||
dev_err(dev, "wrong number of EPs (zero)\n");
|
||||
ret = -EINVAL;
|
||||
goto err_supplies;
|
||||
}
|
||||
|
||||
|
@ -3606,6 +3607,7 @@ static int __devinit s3c_hsotg_probe(struct platform_device *pdev)
|
|||
GFP_KERNEL);
|
||||
if (!eps) {
|
||||
dev_err(dev, "cannot get memory\n");
|
||||
ret = -ENOMEM;
|
||||
goto err_supplies;
|
||||
}
|
||||
|
||||
|
@ -3622,6 +3624,7 @@ static int __devinit s3c_hsotg_probe(struct platform_device *pdev)
|
|||
GFP_KERNEL);
|
||||
if (!hsotg->ctrl_req) {
|
||||
dev_err(dev, "failed to allocate ctrl req\n");
|
||||
ret = -ENOMEM;
|
||||
goto err_ep_mem;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue